10 - Final steps
Open PRs to the relevant repositories. The order specified here (atmospheric_physics, CAM, then CAM-SIMA) is the preferred ordering of PRs/testing/merging. The reason for this is that atmospheric_physics has to go first to get a tag for both CAM and CAM-SIMA. Then the robust testing within CAM will validate the physics, resulting in increased confidence for bringing it into CAM-SIMA.
It is also good practice to not let there be too much time between merging your atmospheric_physics PR and your CAM-SIMA PR, as the CAM-SIMA registry and the physics metadata are very closely linked and can cause problems for other developers if they are out of sync.
atmospheric_physics
Follow the atmospheric_physics workflow to open a PR, respond to review requests, and populate the NamesNotInDictionary.txt
file.
CAM
Follow the CAM workflow to open a PR and respond to review requests. Be sure to include the ccpp-conversion
label on your PR. Once you are assigned a tag by the gatekeeper, run the tests, update the Changelog, then make the tag and archive the baselines.
CAM-SIMA
- Add a new test for your scheme using the before/after snapshots you generated during conversion. You can parallel existing FPHYStest tests and follow the instructions here.
- Follow the CAM-SIMA workflow to open a PR, run the regression tests, and (potentially) make a tag. At the very least, you will have the testing updates above and a new atmopsheric_physics hash (which will point to your fork until the atmospheric_physics PR is merged).
Final touches
- Once all PRs are merged and tagged, check off the scheme as "Converted" in the spreadsheet.